[flashrom] [commit] r971 - trunk

repository service svn at flashrom.org
Tue Mar 23 00:47:38 CET 2010

Author: hailfinger
Date: Tue Mar 23 00:47:38 2010
New Revision: 971
URL: http://flashrom.org/trac/coreboot/changeset/971

JEDEC ID probing checks the parity of the vendor ID and verifies that
the ID differs from the flash chip contents.
Add the same feature to 82802AB ID probing.

This should reduce the number of lines we have to look at to determine
if we're missing a chip definition or if we need a board enable. Just
use grep on the log:
grep -v "parity violation"
To narrow it down further, try:
grep -v "id1 is normal flash content, id2 is normal flash content"
And of course you want to ignore the skipped probes:
grep -v "skipped"
The remaining lines are worth examining, and if those look bogus as
well, you can bet that we just need a board enable.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>


Modified: trunk/82802ab.c
--- trunk/82802ab.c	Tue Mar 23 00:43:51 2010	(r970)
+++ trunk/82802ab.c	Tue Mar 23 00:47:38 2010	(r971)
@@ -47,6 +47,7 @@
 	chipaddr bios = flash->virtual_memory;
 	uint8_t id1, id2;
+	uint8_t flashcontent1, flashcontent2;
 	/* Reset to get a clean state */
 	chip_writeb(0xFF, bios);
@@ -64,8 +65,21 @@
-	printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2);
+	printf_debug("%s: id1 0x%02x, id2 0x%02x", __func__, id1, id2);
+	if (!oddparity(id1))
+		printf_debug(", id1 parity violation");
+	/* Read the product ID location again. We should now see normal flash contents. */
+	flashcontent1 = chip_readb(bios);
+	flashcontent2 = chip_readb(bios + 0x01);
+	if (id1 == flashcontent1)
+		printf_debug(", id1 is normal flash content");
+	if (id2 == flashcontent2)
+		printf_debug(", id2 is normal flash content");
+	printf_debug("\n");
 	if (id1 != flash->manufacture_id || id2 != flash->model_id)
 		return 0;

More information about the flashrom mailing list