[flashrom] [PATCH] Reduce message severity level for skipped chips
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Mon Mar 22 23:30:58 CET 2010
Old verbose log excerpt:
Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible.
New verbose log excerpt:
Probing for Atmel AT25DF021, 256 KB: skipped.
This makes logs more readable and manageable. If someone really
desperately wants all the bus debugging stuff, he/she can switch to SPEW
mode instead of VERBOSE mode.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Index: flashrom-skip_bus_nonverbose/flashrom.c
===================================================================
--- flashrom-skip_bus_nonverbose/flashrom.c (Revision 969)
+++ flashrom-skip_bus_nonverbose/flashrom.c (Arbeitskopie)
@@ -877,20 +877,24 @@
for (flash = first_flash; flash && flash->name; flash++) {
if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0)
continue;
- printf_debug("Probing for %s %s, %d KB: ",
+ msg_gdbg("Probing for %s %s, %d KB: ",
flash->vendor, flash->name, flash->total_size);
if (!flash->probe && !force) {
- printf_debug("failed! flashrom has no probe function for this flash chip.\n");
+ msg_gdbg("failed! flashrom has no probe function for "
+ "this flash chip.\n");
continue;
}
buses_common = buses_supported & flash->bustype;
if (!buses_common) {
tmp = flashbuses_to_text(buses_supported);
- printf_debug("skipped. Host bus type %s ", tmp);
+ msg_gdbg("skipped.");
+ msg_gspew(" Host bus type %s ", tmp);
free(tmp);
tmp = flashbuses_to_text(flash->bustype);
- printf_debug("and chip bus type %s are incompatible.\n", tmp);
+ msg_gspew("and chip bus type %s are incompatible.",
+ tmp);
free(tmp);
+ msg_gdbg("\n");
continue;
}
--
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth
More information about the flashrom
mailing list