[flashrom] [PATCH] flashrom DOS support take2 (plus patch for pciutils)

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> 
> I added a short version of your description to the flashrom README.

Ok


> I made some more changes to the Makefile. "make dos" is something I'd
> rather avoid because it hardcodes too many assumptions.

I would prefer to have there something like:

make djgpp-dos

because I will tend to forgot how to invoke the make from command line.


> 
>> Index: physmap.c
>> ===================================================================
>> --- physmap.c	(revision 935)
>> +++ physmap.c	(working copy)
>> @@ -4,6 +4,7 @@
>>   * Copyright (C) 2009 Peter Stuge <peter at stuge.se>
>>   * Copyright (C) 2009 coresystems GmbH
>>   * Copyright (C) 2010 Carl-Daniel Hailfinger
>> + * Copyright (C) 2010 Rudolf Marek <r.marek at assembler.cz>
>>   *
>>   * This program is free software; you can redistribute it and/or modify
>>   * it under the terms of the GNU General Public License as published by
>> @@ -27,7 +28,77 @@
>>  #include <errno.h>
>>  #include "flash.h"
>>  
>> -#ifdef __DARWIN__
>> +#ifdef __DJGPP__
>> [...]
>> +#elif __DARWIN__
>>   
> 
> Can you change this to
> #elif defined(__DARWIN)
> to keep the logic as it was? I don't have a Mac OS X machine, so I can't
> test...

yes sorry fixed.

> 
> 
>> +
>>  #include <DirectIO/darwinio.h>
>>  
>>  #define MEM_DEV "DirectIO"
>>   
> 
> If you drop the board_enable.c hunk (and if my latest Makefile+README
> patch is OK for you), this is
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> I can update the README once your pciutils patch has been merged.
> 

I dont know who can commit this, I'm attaching the fixed patch.

Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Please check that in, so at least something is there ;)
The libpci fixes etc can wait until Martin shows up.

Thanks,
Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkugCPEACgkQ3J9wPJqZRNUqWQCdErhzjgjP8JpAJoyJk1uNPNiD
/AgAoNf9oyKTxSFfsBlyvwFo+kwtx3el
=SS6P
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dos3.patch
Type: text/x-diff
Size: 7206 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100316/473d0220/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dos3.patch.sig
Type: application/octet-stream
Size: 72 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100316/473d0220/attachment.obj>