[flashrom] [PATCH] Fix non-FWH chips with FWH-like commands

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Mar 15 05:08:08 CET 2010

On 14.03.2010 16:28, Carl-Daniel Hailfinger wrote:
> On 14.03.2010 01:13, Michael Karcher wrote:
>> Flash registers are not mapped on these chips, but the unprotection
>> code in erase_82802ab_block tried to access them.
>> Signed-off-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
> I have a patch which switches these chips to use FEATURE_BITS. Let me
> dig it up.

OK, since r937 it should be possible to avoid the check for chip bus
type. With that changed, the patch is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Admittedly I could have skipped acking this since Sean already reviewed
it, but you were so friendly to review my patch and I felt it was only
fair to do the same in return.


"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth

More information about the flashrom mailing list