[flashrom] [PATCH] Check if an erase is needed to write

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Mar 8 01:44:09 CET 2010

On 27.02.2010 08:00, David Hendricks wrote:
> Stefan made a good point about it only applying to serial flash chips. But
> as Carl-Daniel noted, this functionality is not used by anything at all
> currently. Perhaps a comment or something can be added to note that it
> should only be used for chips conforming to Intel's multiple page write
> spec?

I added a lengthy comment about usage and about how the code applies to
chips. The good thing about the code is that with proper annotation in
struct flashchip, the code is usable for every chip out there regardless
of chip conformance with said Intel spec.

> On Fri, Feb 26, 2010 at 7:39 PM, Sean Nelson <audiohacked at gmail.com> wrote:
>> I see no problem with the patch, and it isn't bit-rotten or interferes with
>> anything.
>> Acked-by: Sean Nelson <audiohacked at gmail.com>
> Agreed. FWIW,
> Acked-by: David Hendricks <dhendrix at google.com>

Thanks for the reviews!
Committed in r927.


"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth

More information about the flashrom mailing list