[flashrom] [PATCH 1/2] W83627x code unification

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Sun Jun 27 17:08:11 CEST 2010


Am Samstag, den 26.06.2010, 22:18 -0700 schrieb Sean Nelson:
> On 6/26/10 6:54 AM, Michael Karcher wrote:
> > This patch unifies the code for different Winbond W83627-family chips,
> > to be applied before I add another W83627 GPIO raise function.
> >
> > Signed-off-by: Michael Karcher<flashrom at mkarcher.dialup.fu-berlin.de>
> >    
> I've double checked with the datasheets, proof read, and did a compile 
> test. I only saw one typo which I noted. Otherwise:
> 
> Acked-by: Sean Nelson <audiohacked at gmail.com>

Thank you very much for reviewing this patch! I know that these amounts
of restructuring while changing from a code-driven to a data-driven
approach are really a pain in the neck to review.

Befor committing, I remembered that I forgot to check for unimplemented
ports, and added this test, too.

The result is r1062.

Regards,
  Michael Karcher





More information about the flashrom mailing list