[flashrom] [PATCH] Neuter probe for ITE SuperIO

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Wed Jun 23 12:02:39 CEST 2010


Am Mittwoch, den 23.06.2010, 10:30 +0200 schrieb Carl-Daniel Hailfinger:
> Due to the reasons stated above, this patch can't be applied, but there
> are two options which might help:
> 1. Blacklist ITE Super I/O probing on your board.
> This would mean we have to change the code flow to run
> chipset_flash_enable(); board_flash_enable(); probe_superio();
> it87xx_probe_spi_flash(); instead of the current order probe_superio();
> chipset_flash_enable(); it87xx_probe_spi_flash(); board_flash_enable();

This breaks the intention of the generic superio code in patchwork. It
assumes you can have a generic "superio_gpio_set" which is called from
the board_enable function, which needs that probe_superio() is run
before. I thus also support option 2 (snipped) that tries to check for
the SMC chip and avoid the ITE probe in that case.

A third route would be (if possible, I didn't check datasheets) to write
a exit_conf_mode_ite which still works on the ITE chip, and does nothing
on the SMC chip.

Regards,
  Michael Karcher





More information about the flashrom mailing list