[flashrom] [PATCH] Various manpage fixes and improvements

Uwe Hermann uwe at hermann-uwe.de
Mon Jun 7 21:49:25 CEST 2010


On Sun, Jun 06, 2010 at 05:30:04PM +0200, Carl-Daniel Hailfinger wrote:
> >  - Mention that you can use -VV or -VVV.
> >   
> 
> -VVV doesn't do anything AFAICS.

Done.

 
> > +(max. 3 times, i.e.
> > +.BR \-VVV )
> >   
> 
> max 2 times
> -VV

Done.

 
> > +for even more debug output.
> >  .TP
> >  .B "\-c, \-\-chip" <chipname>
> > -Probe only for specified flash ROM chip. This option takes the chip name as
> > +Probe only for the specified flash ROM chip. This option takes the chip name as
> >  printed by
> >  .B "flashrom \-L"
> >  without the vendor name. Please note that the chip name is case sensitive.
> >   
> 
> ...without the vendor name as parameter.

Done.


> > -* Force chip access even if the chip is bigger than max decode size for\
> > - the flash bus.
> > +* Force chip access even if the chip is bigger than the maximum decode size\
> >   
> 
> Either "...decoded size..." or "...supported size...". I prefer "supported".

Done.

 
> > -.BR "* ft2232_spi" " (for flash ROMs attached to a FT2232H/FT4232H based USB SPI programmer)"
> > +.BR "* ft2232_spi" " (for SPI flash ROMs attached to a FT2232H/FT4232H based USB SPI programmer)"
> >   
> 
> 80 column limit?

Fixed, also in a few other places.

 
> > -and write (which includes erase).
> > +and write (which also includes the erase step).
> 
> I'd like to keep the original wording here because it fits better with
> the overall sentence structure.

Done.

 
> There's one think I'd love to see changed:
> "Please report any bugs at
> http://www.flashrom.org/trac/flashrom/newticket, or on the flashrom
> mailing list at http://www.flashrom.org/mailman/listinfo/flashrom."
> I have no idea how to make a space appear after each URL. Such a space
> would help in case anyone uses cut-n-paste or automatic link recognition
> which may include the colon or full stop in the URL.

Hm, not such a big issue IMHO, but I changed it so that each URL is on
an extra line so it can be copy-pasted.


> With that in mind, this patch is
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, r1038.

 
Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list