[flashrom] [PATCH] Support for HP DL165 G6

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Jun 7 16:35:19 CEST 2010


On 26.05.2010 19:03, Arne Georg Gleditsch wrote:
> On 26. mai 2010 16:18, Michael Karcher wrote:
>   
>> Maybe because we preferrably choose chips with subsystem IDs. Maybe
>> because someone thought that a new board revision very probably contains
>> a more modern graphics chip. In this case, you are very right in
>> suggesting to take the network chip as secondary PCI ID. You need to
>> find out what subsystem IDs are used (if any) in the DL145 and the
>> DL165.
>>
>> If you send
>>  - lspci -vvvxxxnn, superiotool -deV and flashrom -V output of your
>> DL165 (general requirement for having new boards added),
>>  - an updated patch that uses the network instead of the graphics chip
>> for both boards, including a sign-off[1],
>>  - preferably at least PCI ID info including subsystems for the DL145,
>>     
>
> According to
> http://merlin.ugent.be/~samuel/dl145g3/info/lspci-vnn.txt, the DL145 is
> equipped thus:
>
> 08:04.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5715 Gigabit Ethernet [14e4:1678] (rev a3)
> 	Subsystem: Hewlett-Packard Company NC326i PCIe Dual Port Gigabit Server Adapter [103c:703e]
>
> Full lspci listing and superio and flashrom output for the DL165 follows,
> as well as updated patch.
>
> Signed-off-by: Arne Georg Gleditsch <arne.gleditsch at numascale.com>
>   

Mh. The lspci you linked to suggests that the network card is in a PCI-X
slot and not on board.
I diffed both PCI configurations against each other:

--- dl145.txt   2010-06-07 16:25:52.000000000 +0200
+++ dl165.txt   2010-06-07 16:25:56.000000000 +0200
@@ -1,35 +1,38 @@
 00:01.0 PCI bridge [0604]: Broadcom BCM5785 [HT1000] PCI/PCI-X Bridge [1166:0036]
-       Capabilities: [d8] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [d8] Subsystem: Broadcom BCM5785 [HT1000] PCI/PCI-X Bridge [1166:0036]
 00:02.0 Host bridge [0600]: Broadcom BCM5785 [HT1000] Legacy South Bridge [1166:0205]
        Subsystem: Broadcom Device [1166:0201]
 00:02.1 IDE interface [0101]: Broadcom BCM5785 [HT1000] IDE [1166:0214]
        Subsystem: Hewlett-Packard Company Device [103c:320b]
 00:02.2 ISA bridge [0601]: Broadcom BCM5785 [HT1000] LPC [1166:0234]
-       Subsystem: Broadcom Device [1166:0230]
+       Subsystem: Hewlett-Packard Company Device [103c:320d]
+00:02.3 System peripheral [0880]: Broadcom BCM5785 [HT1000] WDTimer [1166:0238] (rev 01)
+       Subsystem: Broadcom BCM5785 [HT1000] WDTimer [1166:0238]
 00:03.0 USB Controller [0c03]: Broadcom BCM5785 [HT1000] USB [1166:0223] (rev 01)
        Subsystem: Hewlett-Packard Company Device [103c:320c]
 00:03.1 USB Controller [0c03]: Broadcom BCM5785 [HT1000] USB [1166:0223] (rev 01)
        Subsystem: Hewlett-Packard Company Device [103c:320c]
 00:03.2 USB Controller [0c03]: Broadcom BCM5785 [HT1000] USB [1166:0223] (rev 01)
        Subsystem: Hewlett-Packard Company Device [103c:320d]
-00:04.0 VGA compatible controller [0300]: Matrox Graphics, Inc. MGA G200e [Pilot] ServerEngines (SEP1) [102b:0522] (rev 02)
-       Subsystem: Hewlett-Packard Company Device [103c:31fa]
 00:06.0 PCI bridge [0604]: Broadcom HT2100 PCI-Express Bridge [1166:0140] (rev a2)
-       Capabilities: [78] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [78] Subsystem: Hewlett-Packard Company Device [103c:0140]
 00:07.0 PCI bridge [0604]: Broadcom HT2100 PCI-Express Bridge [1166:0142] (rev a2)
-       Capabilities: [78] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [78] Subsystem: Hewlett-Packard Company Device [103c:0142]
 00:08.0 PCI bridge [0604]: Broadcom HT2100 PCI-Express Bridge [1166:0144] (rev a2)
-       Capabilities: [78] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [78] Subsystem: Hewlett-Packard Company Device [103c:0144]
 00:09.0 PCI bridge [0604]: Broadcom HT2100 PCI-Express Bridge [1166:0142] (rev a2)
-       Capabilities: [78] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [78] Subsystem: Hewlett-Packard Company Device [103c:0142]
 00:0a.0 PCI bridge [0604]: Broadcom HT2100 PCI-Express Bridge [1166:0144] (rev a2)
-       Capabilities: [78] Subsystem: Gammagraphx, Inc. (or missing ID) Device [0000:0000]
+       Capabilities: [78] Subsystem: Hewlett-Packard Company Device [103c:0144]
 01:0d.0 PCI bridge [0604]: Broadcom BCM5785 [HT1000] PCI/PCI-X Bridge [1166:0104] (rev c0)
-       Capabilities: [88] Subsystem: Device [c133:a9d6]
+       Capabilities: [88] Subsystem: Hewlett-Packard Company Device [103c:0104]
 01:0e.0 RAID bus controller [0104]: Broadcom BCM5785 [HT1000] SATA (Native SATA Mode) [1166:024a]
        Subsystem: Hewlett-Packard Company Device [103c:320b]
-07:00.0 PCI bridge [0604]: Broadcom EPB PCI-Express to PCI-X Bridge [1166:0103] (rev b5)
-08:04.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5715 Gigabit Ethernet [14e4:1678] (rev a3)
-       Subsystem: Hewlett-Packard Company NC326i PCIe Dual Port Gigabit Server Adapter [103c:703e]
-08:04.1 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5715 Gigabit Ethernet [14e4:1678] (rev a3)
-       Subsystem: Hewlett-Packard Company NC326i PCIe Dual Port Gigabit Server Adapter [103c:703e]
+02:02.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5704 Gigabit Ethernet [14e4:1648] (rev 10)
+       Subsystem: Hewlett-Packard Company Device [103c:310f]
+02:02.1 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5704 Gigabit Ethernet [14e4:1648] (rev 10)
+       Subsystem: Hewlett-Packard Company Device [103c:310f]
+06:00.0 RAID bus controller [0104]: Hewlett-Packard Company Smart Array G6 controllers [103c:323a] (rev 01)
+       Subsystem: Hewlett-Packard Company Device [103c:3241]
+1e:00.0 VGA compatible controller [0300]: Matrox Graphics, Inc. MGA G200e [Pilot] ServerEngines (SEP1) [102b:0522] (rev 02)
+       Subsystem: Hewlett-Packard Company Device [103c:31fa]


Unless we're totally sure the network controllers are onboard for both
boards, I think we should
- use the LPC device subsystem on both boards or
- use the 1166:0103 PCI bridge on DL145 and the 1166:0238 WDTimer on
DL165 or
- use DMI strings and coreboot IDs.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list