[flashrom] [PATCH] Disallow the internal programmer on non-x86 for now

Uwe Hermann uwe at hermann-uwe.de
Fri Jun 4 20:27:42 CEST 2010


On Fri, Jun 04, 2010 at 08:01:21PM +0200, Carl-Daniel Hailfinger wrote:
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Re-tested, looks good.

 
> Index: flashrom-disable_internal_nonx86/internal.c
> ===================================================================
> --- flashrom-disable_internal_nonx86/internal.c	(Revision 1028)
> +++ flashrom-disable_internal_nonx86/internal.c	(Arbeitskopie)
> @@ -165,16 +165,27 @@
>  	pci_init(pacc);		/* Initialize the PCI library */
>  	pci_scan_bus(pacc);	/* We want to get the list of devices */
>  
> -	/* We look at the lbtable first to see if we need a
> +	if (processor_flash_enable()) {
> +		msg_perr("Processor detection/init failed, aborting.");

Missing \n in this message.


> +	 * FIXME: Enable SuperI/O probing once port I/O is possible.

"Super I/O" here for consistency please, forgot to mention last time.


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list