[flashrom] [PATCH] Disallow the internal programmer on non-x86 for now

Uwe Hermann uwe at hermann-uwe.de
Fri Jun 4 18:52:51 CEST 2010


On Wed, May 26, 2010 at 05:07:25AM +0200, Carl-Daniel Hailfinger wrote:
> The internal programmer needs correct information about flash_base and
> chip window top/bottom alignment on non-x86 before it can be used. Abort
> any internal programmer action for now until the code is fixed.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
 

> +#if defined(__i386__) || defined(__x86_64__)
>  	return 0;
> +#else
> +	msg_perr("Your platform is not supported yet for the internal "
> +		 "programmer due to missing flash_base and top/bottom "
                                           ^
Add an \n here please, to make the output look nice in 80x25 terminals/xterms.


> +	/* FIXME: Remove this unconditional abort once all PCI drivers are
> +	 * converted to use little-endian accesses for memory BARs.
> +	 */
> +	msg_perr("Your platform is not supported yet for the internal "
> +		 "programmer because it has not been converted from native "
                                           ^
                                      Ditto here.


Otherwise it looks fine and compiles on x86.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list