[flashrom] [PATCH] Fix AAI code
c-d.hailfinger.devel.2006 at gmx.net
Thu Jul 29 18:32:51 CEST 2010
On 29.07.2010 18:18, Uwe Hermann wrote:
> On Thu, Jun 24, 2010 at 02:41:38AM +0200, Carl-Daniel Hailfinger wrote:
>> The AAI code rewrite in r1052 introduced a bug: The writelen of AAI
>> continuation is 3 bytes, but the code incorrectly had 6 bytes there.
>> This causes all AAI writes (except the first two bytes of a chip) to fail.
>> Thanks to den_m for reporting the bug and for testing the fix.
>> Functional change:
>> Fix AAI continuation command write length (was 6, should be 3).
>> Cosmetic change:
>> Change the whitespace of a few #defines in spi.h to have aligned values
>> to improve readability (maybe someone would have spotted the AAI bug if
>> the values had been aligned in the first place).
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
Thanks, committed in r1121.
More information about the flashrom