[flashrom] [PATCH] drkaiser, gfxnvidia: MEM BAR fixes
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Sun Jul 18 00:48:21 CEST 2010
On 18.07.2010 00:19, Uwe Hermann wrote:
> On Sat, May 08, 2010 at 03:01:15AM +0200, Carl-Daniel Hailfinger wrote:
>
>> Hi Joerg, hi Uwe,
>>
>> could you two please test this patch against latest flashrom on your
>> hardware (Dr. Kaiser FPGA, Nvidia graphics card)?
>>
>> Use the BAR value returned by pcidev_init which automatically applies
>> the correct BAR mask for the drkaiser driver.
>> Truncate flash chip addresses to fit into the 128 kB memory window for
>> drkaiser and pick the same window size for gfxnvidia.
>>
>> Uwe: I'm not sure if 128kB are an appropriate size for gfxnvidia.
>> Looking at the size of the mapping, 8 MB are probably possible, but I
>> have no idea if that mapping is any indicator of possible chip size or
>> just a leftover artifact.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>
>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
>
> Tested all operations successfully on a Dr. Kaiser card. I'll test on an
> NVIDIA card soonish, but no need to wait with the commit.
>
> The patch didn't apply anymore, the updated patch is attached for
> convenience.
>
Thanks, committed in r1089.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the flashrom
mailing list