[flashrom] [PATCH] SPI bitbanging core fixups

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Sat Jul 17 14:44:30 CEST 2010

Am Samstag, den 17.07.2010, 14:35 +0200 schrieb Carl-Daniel Hailfinger:
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
This patch as-is is
Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
According to current flashrom desing I see no technical reason to not
accept the patch.

BUT: We really should think about killing the SPI bitbang master table.
Why not just pass a pointer to a "struct bitbang_spi_master_enty" to
bitbang_spi_init which will then be stored in a static global pointer
instead of a table index as it is done currently? Maybe it's the best
time to do this change now before we merge the bit-bang drivers if this
change is accepted.

  Michael Karcher

More information about the flashrom mailing list