[flashrom] [PATCH] Convert SPI chips to partial write

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Wed Jul 14 18:15:53 CEST 2010


Am Mittwoch, den 14.07.2010, 16:14 +0200 schrieb Carl-Daniel Hailfinger:

> Since we're only handling a very special case
> (round_up_to_next_multiple_of_power_of_two_granularity) and use it only
> one time anyway, it doesn't really make sense to provide a separate
> function for this. Killed as per IRC discussion.
And the single line rewritten as per further IRC discussion. IRC
discussion result:

    lenhere = min(len, (start | 0xff) - start + 1);

> > If you use the bitwise round-up here:
> > Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>

Still stands.
Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>

Regards,
  Michael Karcher





More information about the flashrom mailing list