[flashrom] new chip: AMIC A25L80P

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Jul 12 00:33:40 CEST 2010


Hi Daniel,

thanks for your patch.

On 11.07.2010 21:11, Daniel Lenski wrote:
> On Sun, 2010-07-11 at 20:25 +0200, Michael Karcher wrote:
>   
>> Your patch looks mostly fine. Please add a sign-off according to
>> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
>>
>> Also, please use tabs instead of spaces before the comment in flashchips.h.
>>
>> Except for the tab issue, the patch is
>> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>>     
>
> Got it, thanks.  Corrected patch for AMIC A25L80P attached.
>
> Signed-off-by: Daniel Lenski <dlenski at gmail.com>
>   

Could I interest you in implementing support for all other AMIC A25
series chips as well? Even if you can't test those, it would expand
flashrom coverage a lot.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list