[flashrom] [PATCH] MX25L1605 erase block fixup

[Carl-Daniel Hailfinger]

On 23.01.2010 08:58, Sean Nelson wrote:
> Someone tried to erase the MX25L1605 but the block erasers were
> incorrect. This should fix it.
>
> Signed-off-by: Sean Nelson <audiohacked at gmail.com>

Sorry, this breaks the MX25L1605A which has exactly the same ID, but the
block erasers which are in flashchips.c right now.
Nacked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

The only way out is to duplicate the definition and leave the decision
to users. I even asked Macronix engineers and they said they were not
aware of any way to differentiate between chip variants.

Maybe it is time to introduce FEATURE_EVIL_TWIN and set that for both
chips (in case you create one struct flashchip for each variant). If
more than one chip was found during a flashrom probe run, print a small
message at the end like "A flash chip with an ambiguous ID was found and
flashrom is unable to determine the exact chip. Please pick one of the
detected chips."

Regards,
Carl-Daniel

-- 
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."