[flashrom] [PATCH] Convert chips to block erasers: ST

[Carl-Daniel Hailfinger]

On 19.01.2010 00:21, Sean Nelson wrote:
> On 1/18/2010 2:48 PM, Michael Karcher wrote:
>> I don't think this is going to work. erase_sector_stm50flw0x0x only
>> works on the 4K sectors and not on the 64k blocks inbetween, if I read
>> the datasheet correctly. As I already wrote in the first review:
>> flashrom is currently unable to represent this architecture (different
>> block sizes that have to be delete by different commands), so you better
>> leave it off. Another possible, but a bit hacky, version would be to
>> check sectorsize in erwase_sector_stm50flw0x0x and call
>> erase_block_stm50flw0x0x if sectorsize is 64*1024.
>>
>> Regards,
>>    Michael Karcher
>>
>
> The datasheet doesn't state either way that it wouldn't work on the 5x
> 64k sectors between the 4k blocks, but I'm just going to remove the
> sector erasers and leave the function.

Maybe add a comment in flashchips.c for that chip which says the
structure can't be expressed right now.

Regards,
Carl-Daniel

-- 
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."