[flashrom] [PATCH v2] Enable -Wshadow, clean code for that

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Tue Jan 12 16:38:34 CET 2010

Am Dienstag, den 12.01.2010, 16:30 +0100 schrieb Luc Verhaegen:
> On Tue, Jan 12, 2010 at 10:41:41AM +0100, Michael Karcher wrote:
> > This is not just for fun. We hit a real bug on BSD with the outl macros.
> > The macro variable tmp collided with the tmp from outer scope.
> > 
> > second revision, now also taking care of inb/inw/inl. While that shadowing
> > did not introduce bugs (yet), of course it breaks the build on BSD when
> > -Wshadow is enabled.
> > 
> > Signed-off-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
> Acked-by: Luc Verhaegen <libv at skynet.be>

Thanks, r860.

  Michael Karcher

More information about the flashrom mailing list