[flashrom] [PATCH] Use the register mapping feature bit

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Jan 9 03:26:45 CET 2010


On 09.01.2010 01:07, Michael Karcher wrote:
> Am Donnerstag, den 07.01.2010, 19:31 +0100 schrieb Carl-Daniel
> Hailfinger:
>   
>> Use the register mapping feature bit.
>>     
> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>   

On 09.01.2010 01:37, Sean Nelson wrote:
> Acked-by: Sean Nelson <audiohacked at gmail.com>

Thanks for the reviews, committed in r839.


On 09.01.2010 01:07, Michael Karcher wrote:
>> Index: flashrom-registermap_featurebit/flashchips.c
>> ===================================================================
>> --- flashrom-registermap_featurebit/flashchips.c	(Revision 834)
>> +++ flashrom-registermap_featurebit/flashchips.c	(Arbeitskopie)
>> @@ -827,7 +827,7 @@
>>  		.total_size	= 64,
>>  		.page_size	= 128,
>>  		.tested		= TEST_OK_PRW,
>> -		.probe		= probe_jedec, 
>> +		.probe		= probe_jedec,
>>  		.probe_timing	= 10000, /* 10mS, Enter=Exec */
>>  		.erase		= NULL,
>>  		.block_erasers	=
>>     
> Is this whitespace-only change (removes a trailing space that shouldn't
> have been there from the beginning) intentional?
>   

Yes, but I should have mentioned it in the changelog.
In the future, I should run some check for trailing whitespace on all
commits.


Regards,
Carl-Daniel

-- 
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."





More information about the flashrom mailing list