[flashrom] [RFC] JEDEC refactor w/ conversion notes and file eliminations
audiohacked at gmail.com
Mon Jan 4 18:16:38 CET 2010
On 1/4/2010 6:05 AM, Carl-Daniel Hailfinger wrote:
> On 04.01.2010 07:39, Sean Nelson wrote:
>> The patch converts jedec functions into mask-based generics which can
>> be used for many chip provided the only changes are the the addresses
>> are converted from 0x5555/0x2AAA to 0x555/0x2AA or similar.
>> These functions won't work for the 0xAAA chips listed above, but most
>> of listed chips should work with these changes. The other changes I
>> suggested will come in later patches, and the writing functions are
>> untouched since we'll move to a block writers system.
> Maybe snip the two sentences above from the changelog. (There are no
> "0xAAA chips listed above".)
>> The patch mostly changes jedec.c, but a few other files are changed
>> because they use the jedec functions within their own functions.
>> The patch also adds a copyright line to flashchips.c because of my
>> recent work in converting AMD and Atmel chips to use struct erase_block.
>> Signed-off-by: Sean Nelson<audiohacked at gmail.com>
> Very nice.
> Acked-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
Thanks, committed in r828.
More information about the flashrom