[flashrom] [PATCH] split spi.c and fix include headers
c-d.hailfinger.devel.2006 at gmx.net
Thu Feb 25 23:30:35 CET 2010
On 25.02.2010 21:50, Sean Nelson wrote:
> Updated against svn with suggestions.
I really like this patch, but I noticed we're doing two things at once,
and some of my suggestions (which you followed) has unintended side
effects (which are note really desirable). This is my fault and I'll
take the blame.
One part of this patch splits the include files (including all the nasty
hwaccess.h stuff), and another part makes all chip drivers use
chipdrivers.h and splits spi.c into spi.c and spi25.c.
Could you split off the chipdriver stuff (including the spi.c split) and
send it as separate patch? All the chipdriver stuff is committable and
looks fine. Here's a file list you can supply to svn diff (svn diff
takes multiple files as arguments which makes splitting easy):
82802ab.c flashchips.c jedec.c m29f400bt.c Makefile pm49fl00x.c
sharplhf00l04.c spi25.c spi.c sst28sf040.c sst49lfxxxc.c sst_fwhub.c
stm50flw0x0x.c w29ee011.c w39v040c.c w39v080fa.c
I checked that the chipdriver stuff is standalone and compiles just
fine. That part is immediately ackable.
The programmer/hwaccess stuff turned out to be more complicated than I
had hoped. I'd like to postpone that part until we know how to keep all
programmer stuff in one header file... If you want to svn revert those
files (keep the diff around, I believe the work you did was valuable),
here's a list:
board_enable.c buspirate_spi.c chipset_enable.c dediprog.c drkaiser.c
flash.h flashrom.c hwaccess.c hwaccess.h ichspi.c internal.c it87spi.c
nic3com.c pcidev.c physmap.c print.c satasii.c sb600spi.c wbsio_spi.c
Sorry for not seeing the PCI splitoff mess before.
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth
More information about the flashrom