[flashrom] [PATCH] chipdrivers cleanup
c-d.hailfinger.devel.2006 at gmx.net
Mon Feb 22 21:06:15 CET 2010
On 22.02.2010 19:54, Sean Nelson wrote:
> Remove remaining JEDEC chipdrivers, but move lock-related functions to
> Fix whitespace for ST_M29W512B.
> SVN RM: (maybe not now; as a note)
> w39v040c.c - only function in use left is printlock_w39v040c
> w39v080fa.c - function names state *_winbond_fwhub but this is JEDEC;
> only functions used are lock related
> pm49fl00x.c - finally converted to JEDEC
> sst_fwhub.c - contrary to function/file names this is JEDEC
I'm not totally happy with the idea of throwing all locking stuff into
one file. Once we expand the locking functions, they might as well grow
in size to a point where we want to separate them again. It would be
cool to group locking functions somewhat according to the method they
use, and create a file per group.
Side note: A patch which simply removes dead code and keeps non-empty
files around (without the dead code) would be a bit easier to review and
enable us to worry about reducing the number of files later.
> Signed-off-by: Sean Nelson <audiohacked at gmail.com>
No review yet (lack of time), but a small note:
If you copy code from existing files, you have to carry the relevant
copyright notices over (either all of them, or use svn blame to find out
who wrote the code, then check if the "original" author copied and
forgot to credit the real original author).
P.S. Given the recent growth in the programmer driver area, now might be
a good time to think about splitting the code into multiple subdirs. I
know I rejected that idea earlier, but I never expected flashrom to be
that successful in the programmer driver department.
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth
More information about the flashrom