[flashrom] [PATCH] quick fix for chip locks

[Carl-Daniel Hailfinger]

On 19.02.2010 01:11, Sean Nelson wrote:
> On 2/18/10 3:46 PM, Sean Nelson wrote:
>> Here's a very quick patch to fix the missing unlock code.
>> Fixes missing unlock for certain chips:
>> Fixes missing printlock for certain chip:
>>
>> Signed-off-by: Sean Nelson <audiohacked at gmail.com>
>>
>> Let's get this regression fixed ASAP.
>
> Updated patch so that unlock is done only on read/write/erase, and
> printlock returns 0.

Thanks. My earlier review applies in spirit. On top of it, I noticed this:
> Index: flashchips.c
> ===================================================================
> --- flashchips.c	(revision 906)
> +++ flashchips.c	(working copy)
> @@ -43,18 +43,20 @@
>  	 * .page_size		= Page or eraseblock(?) size in bytes
>  	 * .tested		= Test status
>  	 * .probe		= Probe function
>  	 * .probe_timing	= Probe function delay
>  	 * .block_erasers[]	= Array of erase layouts and erase functions
>  	 * {
>  	 *	.eraseblocks[]	= Array of { blocksize, blockcount }
>  	 *	.block_erase	= Block erase function
>  	 * }
> +	 * .printstatus		= Chip lock status function
>   

AFAIK it is called printlock everywhere else.

> +	 * .unlock		= Chip unlock function
>   

Regards,
Carl-Daniel

-- 
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth