[flashrom] [PATCH] Refactor MCP SPI detection

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Thu Feb 18 09:06:22 CET 2010

Am Donnerstag, den 18.02.2010, 03:46 +0100 schrieb Carl-Daniel
> +	} else if (!mcp_spibaraddr && (buses_supported & CHIP_BUSTYPE_SPI)) {
> +		msg_pdbg("Strange. MCP SPI BAR is invalid.\n");
> +		buses_supported &= ~CHIP_BUSTYPE_SPI;
You might want to set ret to 1 here.

Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
You can use the Ack for either version (with or with ret=1 at the point
quoted above).

  Michael Karcher

More information about the flashrom mailing list