[flashrom] [PATCH] Avoid SPI RES if REMS is available
c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 12 20:37:55 CET 2010
On 12.02.2010 19:49, Sean Nelson wrote:
> On 2/12/10 7:39 AM, Carl-Daniel Hailfinger wrote:
>> SPI RES is the most unreliable way to identify chips because it only
>> returns a 1-byte ID for most chips. For every given ID out there,
>> probably a dozen incompatible flash chips match it.
>> We already refuse to identify a chip with RES if that chip responds to
>> RDID (3 bytes, good match), and with this patch we additionally refuse
>> RES if the chip responds to REMS (2 bytes, still a good match). This
>> increases matching accuracy a lot.
>> Besides that, the RDID/REMS response checking has been cleaned up for
>> better readability.
>> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Sean Nelson <audiohacked at gmail.com>
Thanks, committed in r899.
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."
More information about the flashrom