[flashrom] [PATCH] Handle denied access to cbtable gracefuly
c-d.hailfinger.devel.2006 at gmx.net
Mon Feb 1 12:55:14 CET 2010
can you please try this patch on top of an unmodified flashrom source?
It is available for download at http://patchwork.coreboot.org/patch/861/raw/
On 01.02.2010 05:41, Carl-Daniel Hailfinger wrote:
> Stefan: Could you please test this one on Mac OS X? In theory it should
> even allow us to kill the start=0x400 special case for Mac OS X.
> Create a physical memory mapping function which requests cached readonly
> memory. This should take care of picky Linux kernels which do not allow
> uncached mappings to cached areas.
> Handle mapping failure gracefully (no forced exit()) if the caller
> specifies it.
> Such cached areas which can handle mapping failure are DMI tables and
> coreboot tables. On retry and repeated failure we just ignore those
> tables. That is not perfect, but a lot better than aborting flashrom due
> to an error in nonessential functionality.
> This should fix flashrom on a sizable number of machines where it
> currently aborts early.
> Yes, I could have exploited a Linux kernel bug to "solve" this, but
> relying on such bugs is not exactly the best idea.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Please run "flashrom -V", send us the output and if detection works for
you, please add the following line to your mail:
Acked-by: Vincent Pelletier <your at email.address>
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."
More information about the flashrom