[flashrom] [patch] compilation fix for djgpp

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Sun Dec 26 19:23:07 CET 2010


Am Montag, den 06.12.2010, 18:01 +0100 schrieb Idwer Vollering:
> This corrects a djgpp build error, seen with r1232 and later.
> 
> Signed-off-by: Idwer Vollering <vidwer at gmail.com>
Not acked...

> -int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data)
> +int rpci_write_long(struct pci_dev *dev, int reg, u32 data)

> pcidev.c:210: error: conflicting types for 'rpci_write_long'
> programmer.h:226: error: previous declaration of 'rpci_write_long' was
> here

I'd rather patch the header file to use uint32_t/uint16_t/uint8_t
instead of u8/u16/u32, as the former types are used throughout flashrom.
Is there any reason to not use them on rpci_write_*?

Regards,
  Michael Karcher






More information about the flashrom mailing list