[flashrom] [PATCH] Fixed decoding of SB600 LPC ROM protection registers

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Dec 22 02:33:04 CET 2010


Hi Mathias,

thanks for your patch.

Minor nitpick:

On 21.12.2010 16:17, Mathias Krause wrote:
> (prot & 0xfffff800) + (((((prot & 0x7fc) >> 2) + 1) << 10) - 1));
>   

This one looks a bit odd. How about

(prot & 0xfffff800) + ((((prot & 0x7fc) >> 2) << 10) | 0x3ff);


Looks good otherwise.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list