[flashrom] [PATCH] Do not crash with forced chips

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Dec 2 23:02:02 CET 2010


On 02.12.2010 21:56, Uwe Hermann wrote:
> On Thu, Dec 02, 2010 at 01:55:53PM +0100, Carl-Daniel Hailfinger wrote:
>   
>> Avoid printing the chip locks if chip detection was forced because lock
>> access may involve flash chip registers which will not be mapped.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
>   

Thanks, committed in r1240.


> Looks good. Maybe add a small message to inform the user about this?
>   

Not sure. This is for forced detection only, and there you can't read
the locking status for most chips anyway because the chip didn't respond
in the first place. And for pure read of a chip it is not clear whether
printing locks would make sense.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list