[flashrom] [PATCH] Do not crash with forced chips
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Thu Dec 2 13:55:53 CET 2010
Avoid printing the chip locks if chip detection was forced because lock
access may involve flash chip registers which will not be mapped.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Index: flashrom-no_force_register_access/flashrom.c
===================================================================
--- flashrom-no_force_register_access/flashrom.c (Revision 1238)
+++ flashrom-no_force_register_access/flashrom.c (Arbeitskopie)
@@ -1163,8 +1163,12 @@
flash->vendor, flash->name, flash->total_size,
flashbuses_to_text(flash->bustype), base);
- if (flash->printlock)
- flash->printlock(flash);
+ /* Flash registers will not be mapped if the chip was forced. Lock info
+ * may be stored in registers, so avoid lock info printing.
+ */
+ if (!force)
+ if (flash->printlock)
+ flash->printlock(flash);
return flash;
}
--
http://www.hailfinger.org/
More information about the flashrom
mailing list