[flashrom] [PATCH] Check availability of GPO lines on Intel PIIX4

[Mattias Mattsson]

On Sun, Aug 15, 2010 at 11:37, Michael Karcher
<flashrom at mkarcher.dialup.fu-berlin.de> wrote:
> One question remaining: Why do you think GPO8 is "never available". The
> only special behaviour about GPO8 I could find in the data sheet is that
> GPO8 has a defined low level in standby mode, but it should work as
> usual in all other modes.

While experimenting I found that some board immediately powered off
when lowering GPO8 (think it was a Dell, unfortunately it's dead now).
Therefore I made the assumption that it was unsafe to fiddle with.
Today I did some more testing with a modified flashrom. When lowering
GPO8 on these boards (all with PIIX4) the following happens:

Asus P2B-N: Nothing
Asus P2E-M: Nothing
Intel SE440BX: Kernel crash
MSI MS-6163 Pro: Nothing

It seems safe in most cases so I decided to just remove the
forbidden_gpos variable and mark GPO8 as always available.

Also I marked all board enables using intel_piix4_gpo_set as untested
(and renamed the function to the more generic form).

New patch attached


Thanks!
-mattias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: piix4_gpo-v3.patch
Type: application/octet-stream
Size: 4790 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100815/74ad4cd1/attachment.obj>