[flashrom] [PATCH] nicnatsemi.c: Typo. s/are apparently don't/apparently don't/

David Borg borg.db at gmail.com
Sat Aug 7 14:51:09 CEST 2010


On 13 June 2010 00:06, Andrew Morgan <ziltro at ziltro.com> wrote:
>
> On 12/06/10 22:28, Carl-Daniel Hailfinger wrote:
>>
>> On 12.06.2010 22:52, Paul Menzel wrote:
>>
>>>
>>> -        * Bit 8-31 of this register are apparently don't care, and if this
>>> +        * Bit 8-31 of this register apparently don't care, and if this
>>>
>>>
>>
>> "don't care" is used as a compound adjective and the verb in the
>> compound adjective is ignored in that case. Please see
>> http://en.wikipedia.org/wiki/Don%27t-care_(logic) for details. It is
>> possible to improve readability slightly with the following variant:
>>
>> Bit 8-31 of this register are apparently don't-care bits, and...

I think just saying:

 * Bits 8-31 of this register are apparently don't care, ...

should be enough. Just use the plural as a range of bits is being specified.

Attached patch does just that, and fixes a missing comma on the following line.

>>
>> Not sure if this is really better, and we probably should ask a native
>> speaker who works with hardware logic.
>>

I'm not a native speaker, but English is my second language :P

>
> I would be tempted to put:
> are "don't care"
> with the quotes, if it is quoting the datasheet?
>
> --
>
> Andrew.
>

I don't think that's necessary.

Signed-off-by: David Borg <borg.db at gmail.com>
Acked-by: David Borg <borg.db at gmail.com> (trivial)

-- 
David Borg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_comment_nicnatsemi_trivial.patch
Type: text/x-patch
Size: 1269 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100807/5de75ec6/attachment.patch>


More information about the flashrom mailing list