[flashrom] dell s1850

[Carl-Daniel Hailfinger]

On 19.09.2009 02:04, ron minnich wrote:
> here's the lspci
>   

Thanks. To be honest, I think our PCI ID tables need a lot more IDs to
be accurate, but for now I picked the following devices as trigger:
Intel E7520 Memory Controller Hub (with Dell subsystem)
LSI/symbios/NCR 53c1030 PCI-X Fusion-MPT Dual Ultra320 SCSI (with Dell
subsystem)
If you think other dell boards may have these devices as well, we
probably have to kill the subsystem ID for one of them to disable
automatic matching.

The only thing left to do is to replace XX with the correct GPIO number
(between 16 and 31). After that it should work. I couldn't find the GPIO
number in any of your mails, but you said you used the GPIO finder
program, so a dump/output from that program would help me pick the
correct number.

I picked "dell","s1850" as coreboot IDs for now. However, please note
that the dell/s1850 target in the coreboot v2 tree has completely
incorrect IDs which should be fixed:
default CONFIG_MAINBOARD_PART_NUMBER="X6DHR"
default CONFIG_MAINBOARD_VENDOR=     "Supermicro"
default CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID=0x15D9
default CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID=0x5580

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: flashrom-boardenable_dell_s1850/board_enable.c
===================================================================
--- flashrom-boardenable_dell_s1850/board_enable.c	(Revision 725)
+++ flashrom-boardenable_dell_s1850/board_enable.c	(Arbeitskopie)
@@ -569,6 +569,17 @@
 }
 
 /**
+ * Suited for the Dell S1850. All parameters except the last one are documented
+ * in the public Intel 82801EB ICH5 / 82801ER ICH5R Datasheet. The last
+ * parameter (GPIO number) has to be in the range [16,31] according to said
+ * Intel Datasheet and can be found by exhaustive search.
+ */
+static int ich5_gpioXX_raise(const char *name)
+{
+	return ich_gpio_raise(name, 0x8086, 0x24d0, 0x58, 0x0c, 0xffc0, XX);
+}
+
+/**
  * Suited for MSI MS-7046.
  */
 static int ich6_gpio19_raise(const char *name)
@@ -992,6 +1003,7 @@
 	{0x8086, 0x2570, 0x1043, 0x80F2,  0x105A, 0x3373, 0x1043, 0x80F5, NULL,         NULL,          "ASUS",        "P4P800-E Deluxe",    board_asus_p4p800},
 	{0x10B9, 0x1541,      0,      0,  0x10B9, 0x1533,      0,      0, "asus",       "p5a",         "ASUS",        "P5A",                board_asus_p5a},
 	{0x1106, 0x3149, 0x1565, 0x3206,  0x1106, 0x3344, 0x1565, 0x1202, NULL,         NULL,          "Biostar",     "P4M80-M4",           it8705_rom_write_enable},
+	{0x8086, 0x3590, 0x1028, 0x016c,  0x1000, 0x0030, 0x1028, 0x016c, "dell",       "s1850",       "Dell",        "S1850",              ich5_gpioXX_raise},
 	{0x1106, 0x3038, 0x1019, 0x0996,  0x1106, 0x3177, 0x1019, 0x0996, NULL,         NULL,          "Elitegroup",  "K7VTA3",             it8705f_write_enable_2e},
 	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3059, 0x1695, 0x3005, NULL,         NULL,          "EPoX",        "EP-8K5A2",           board_epox_ep_8k5a2},
 	{0x8086, 0x7110,      0,      0,  0x8086, 0x7190,      0,      0, "epox",       "ep-bx3",      "EPoX",        "EP-BX3",             board_epox_ep_bx3},


-- 
http://www.hailfinger.org/