[flashrom] [PATCH] LLVM/clang code review

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Sep 15 23:08:23 CEST 2009


Hi,

On 15.09.2009 19:49, Stefan Reinauer wrote:
> this patch fixes all 27 flashrom source code issues reported by
> LLVM/clang's scan-build (r79326, new build on the way).
>   

It does fix the warnings, but it papers over some of the bugs found by
scan-build. Given that the real bugfixes would have to revert parts of
the patch, please hold off committing. I'll post a detailed review later.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list