[flashrom] [PATCH] Add Suport for Dr.Kaiser PC-Waechter

[Jörg Fischer]

Hi,
Uwe Hermann schrieb:

>> Unrelated issue: My OpenSUSE 11.2 Beta Box needs
>> "make CFLAGS=-fno-strict-aliasing"
>> GCC is "gcc version 4.4.1 [gcc-4_4-branch revision 149935] (SUSE Linux)"
> 
> Can you post the full build output of your compiler here, so we can fix
> the actual issue (so that fno-strict-aliasing is hopefully no longer
> needed).

Here it is:
cc -Os -Wall -Werror  -D'SERPROG_SUPPORT=1'
-D'FLASHROM_VERSION="0.9.1-runknown"' -o physmap.o -c physmap.c
cc1: warnings being treated as errors
physmap.c: In function ârdmsrâ:
physmap.c:146: error: dereferencing type-punned pointer will break
strict-aliasing rules
make: *** [physmap.o] Fehler 1

This issue has already been reported on this list.

> Please also send the output of 'lspci -vvvxxx' for reference, and the
> output of a sample write operation of flashrom (flashrom -w foo.bin)
> if possible. Thanks!

Both attached.

>> +#define PCI_MAGIC_DRKAISER_VALUE 0xA971
> [...]
>> +	pci_write_word(pcidev_dev,PCI_MAGIC_DRKAISER_ADR, PCI_MAGIC_DRKAISER_VALUE);
> 
> Do you know if the magic value above is completely required? Maybe it's
> just one of the bits in there that needs to be toggled? Theoretically
> this could even be tested using the hardware (toggle one of the bits,
> check if writing works; if not, toggle the next bit etc. etc.)

Checked all 2^16 combinations: Only the "magic" one works. All bits are
significant.
 	
> 
>> +	// Map 128KB Flash Memory Window
>> +	drkaiser_mem=physmap("Dr.Kaiser PC-Waechter FLASH Memory",
>> +	pci_read_long(pcidev_dev,PCI_BASE_ADDRESS_2), 128*1024); 
> 
> Are you sure 128 KB is the maximum supported size here? The chip on your
> board is 128KB, but maybe if bigger chips were soldered on instead they
> would still work (depends on the FPGA, hardware wiring etc, I guess)?

All "Dr.Kaiser" Cars that I've seen so far have exactly the same Flash
chip, even the ones that are plugged into a socket (of the NIC version),
probably due to a limit of their original software.

-- J. Fischer
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: flashrom_write.txt
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20090904/8ece5d10/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lspci.txt
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20090904/8ece5d10/attachment-0001.txt>