[flashrom] [PATCH] Standardize on using __func__ instead of __FUNCTION__

Stefan Reinauer stepan at coresystems.de
Wed Sep 2 18:23:07 CEST 2009


Uwe Hermann wrote:
> See patch.

For all debugging messages:
Acked-by: Stefan Reinauer <stepan at coresystems.de>

But this:

> Index: ft2232_spi.c
> ===================================================================
> --- ft2232_spi.c	(Revision 710)
> +++ ft2232_spi.c	(Arbeitskopie)
> @@ -285,7 +285,7 @@
>  			l = total_size - i;
>  
>  		if ((r = spi_nbyte_program(i, &buf[i], l))) {
> -			fprintf(stderr, "%s: write fail %d\n", __FUNCTION__, r);
> +			fprintf(stderr, "%s: write fail %d\n", __func__, r);
>  			return 1;
>  		}
>  		
Error messages (ie. not _debugging_ messages) should not contain 
function names and numbers but descriptive error messages.







More information about the flashrom mailing list