[flashrom] [commit] r708 - trunk

svn at flashrom.org svn at flashrom.org
Wed Sep 2 15:43:56 CEST 2009


Author: hailfinger
Date: 2009-09-02 15:43:56 +0200 (Wed, 02 Sep 2009)
New Revision: 708

Modified:
   trunk/internal.c
Log:
Don't abort if chipset init failed because the failing init may have
been a warning only.
Even a failing chipset init (maybe due to unknown chipset) could still
get us reasonable probe results or at least forced reads.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Modified: trunk/internal.c
===================================================================
--- trunk/internal.c	2009-09-02 00:24:26 UTC (rev 707)
+++ trunk/internal.c	2009-09-02 13:43:56 UTC (rev 708)
@@ -130,7 +130,11 @@
 
 	board_flash_enable(lb_vendor, lb_part);
 
-	return ret; 
+	/* Even if chipset init returns an error code, we don't want to abort.
+	 * The error code might have been a warning only.
+	 * Besides that, we don't check the board enable return code either.
+	 */
+	return 0; 
 }
 
 int internal_shutdown(void)





More information about the flashrom mailing list