[flashrom] [commit] r753 - trunk

svn at flashrom.org svn at flashrom.org
Thu Oct 22 17:07:31 CEST 2009


Author: hailfinger
Date: 2009-10-22 17:07:30 +0200 (Thu, 22 Oct 2009)
New Revision: 753

Modified:
   trunk/ichspi.c
Log:
Since we don't have any debug level printing infrastructure yet, I
propose to kill the obnoxious debug message in ichspi.c which was added
to check for correct PREOP handling. We know the code works fine (after
getting a few reports over 100 MB long) and there's no point in keeping
it around anymore.
If there is any desire, we can reinstate it as print_spew or whatever
once the debug level infrastructure is merged, but at that point we
probably just are happy that the debug output isn't there anymore.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Luc Verhaegen <libv at skynet.be>


Modified: trunk/ichspi.c
===================================================================
--- trunk/ichspi.c	2009-10-21 12:05:50 UTC (rev 752)
+++ trunk/ichspi.c	2009-10-22 15:07:30 UTC (rev 753)
@@ -756,11 +756,8 @@
 			 * opcode of the next command?
 			 */
 			if ((oppos != -1) && (preoppos != -1) &&
-			    (curopcodes->opcode[oppos].atomic - 1 == preoppos)) {
-				printf_debug("opcode 0x%02x will be run as PREOP\n",
-					     cmds->writearr[0]);
+			    ((curopcodes->opcode[oppos].atomic - 1) == preoppos))
 				continue;
-			}
 		}	
 			
 		ret = ich_spi_send_command(cmds->writecnt, cmds->readcnt,





More information about the flashrom mailing list