[flashrom] [PATCH] Boards: Unify all intel ICH GPIO raising.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Oct 22 03:50:53 CEST 2009


On 22.10.2009 02:56, Luc Verhaegen wrote:
> Ok, big change here which will require several of the people on the list 
> below to test and Ack this patch. But one has to admit; the result is 
> worth it.
>   

Before anybody tests:
AFAICS the patch has a bug in the bitmask code which was already present
in the old code, but the new code makes it harder to fix. Besides that,
duplicating pci_dev_find in every board function strikes me as something
that was better in the old code.
I do agree that the old code required too much chipset knowledge into
the board functions, so this patch does improve the situation in that
regard.
Luc, if you want me to go in detail I can do that after I've gotten some
sleep.

So it is pretty likely that we'll see another iteration of the patch
which has to be tested as well...

Regards,
Carl-Daniel

-- 
Developer quote of the week: 
"We are juggling too many chainsaws and flaming arrows and tigers."





More information about the flashrom mailing list