[flashrom] [PATCH] Kill hardcoded block erase on ICH SPI

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Nov 25 03:08:41 CET 2009


On 24.11.2009 15:51, Maciej Pijanka wrote:
> On Mon, 23 Nov 2009, Carl-Daniel Hailfinger wrote:
>
>   
>> Kill hardcoded block erase on ICH SPI.
>> The existing code does not work for all SPI chips, and it just was a
>> band-aid to cope with locked down chipsets back in a time when there was
>> no eraseblock infrastructure.
>> Basically, this unbreaks a few SPI chips on ICH.
>>     
>
> Looks sane for me, but i don't have any ICH/SPI hardware to check, idea seems
> to be right too, because it replace hardcoded one-of-erase-types with chip-based
> erase.
>
> Acked-by: Maciej Pijanka <maciej.pijanka at gmail.com>
>   

Thanks, r777.

Regards,
Carl-Daniel

-- 
Developer quote of the month: 
"We are juggling too many chainsaws and flaming arrows and tigers."





More information about the flashrom mailing list