[flashrom] [PATCH] Move serial handling from serprog.c to serial.c

Uwe Hermann uwe at hermann-uwe.de
Mon Nov 23 16:33:47 CET 2009


On Sat, Nov 21, 2009 at 01:29:11PM +0100, Carl-Daniel Hailfinger wrote:
> Move serial handling from serprog.c to serial.c.
> This is the first step in enabling platform independent serprog and it
> also allows other drivers to use serial port functionality without
> requiring serprog.
> 
> Pure code move, no code changed.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Build-tested, worked ok.

 
> +void __attribute__((noreturn)) sp_die(char *msg)
> +{
> +	perror(msg);
> +	exit(1);

EXIT_FAILURE maybe, though I'm not sure we have consistent error codes
everywhere, yet.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the flashrom mailing list