[flashrom] [PATCH] Totally generic SPI chip match

Marc Jones marcj303 at gmail.com
Thu Nov 19 18:27:57 CET 2009


On Thu, Nov 19, 2009 at 9:21 AM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 01.10.2009 11:10, Carl-Daniel Hailfinger wrote:
>> On 23.07.2009 04:06, Carl-Daniel Hailfinger wrote:
>>
>>> If a chip is not on the RDID generic vendor list nor on the REMS
>>> specific ID list, flashrom will claim that no chip is there. Handle
>>> these cases gracefully. flashrom will ignore generic matches if a
>>> specific chip was found, so this will have no impact on supported chips,
>>> but help a lot for a first quick analysis by the user or developer. The
>>> only drawback is that unknown chips may be recognized multiple times
>>> until they are added to flashchips.[ch].
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>
>>
>> Ping?
>>
>
> Ping? This is the oldest unapplied and unacked patch. It was posted
> almost 4 months ago. (And a on the coreboot list before that.)
> http://patchwork.coreboot.org/patch/67/ if you can't find the patch anymore.
>
> Regards,
> Carl-Daniel

I have no way to test the generic read but the code looks fine.
Acked-by: Marc Jones <marcj303 at gmail.com>

-- 
http://marcjonesconsulting.com




More information about the flashrom mailing list