[flashrom] [PATCH] ICH6-ICH10 flash decode debugging

[Stefan Reinauer]

On 7/28/09 1:25 AM, Carl-Daniel Hailfinger wrote:
> +	for (i = 7; i >= 0; i--)
> +		printf_debug("0xff%02x/0xff%02x FWH decode %sabled, ",
> +			     i * 0x8 + 0xc0, i * 0x8 + 0x80,
> +			     (fwh_conf >> (i + 0x8)) & 0x1 ? "en" : "dis");
> +	for (i = 3; i >= 0; i--)
> +		printf_debug("0xff%02x/0xff%02x FWH decode %sabled, ",
> +			     i * 0x10 + 0x40, i * 0x10,
> +			     (fwh_conf >> i) & 0x1 ? "en" : "dis");

I suggest to write this as

printf_debug("\n0xff%02x0000/0xff%02x0000 FWH decode ...

otherwise it's very hard to see something from the patch

Stefan


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866