[flashrom] [PATCH] Kill spurious cbtable related board enable warning

[Stefan Reinauer]

On 7/27/09 8:27 PM, Carl-Daniel Hailfinger wrote:
> On 27.07.2009 20:00, Stefan Reinauer wrote:
>   
>> On 7/27/09 7:39 PM, Carl-Daniel Hailfinger wrote:
>>   
>>     
>>> Index: flashrom-cbtable_boardenable_nowarn/board_enable.c
>>> ===================================================================
>>> --- flashrom-cbtable_boardenable_nowarn/board_enable.c	(Revision 667)
>>> +++ flashrom-cbtable_boardenable_nowarn/board_enable.c	(Arbeitskopie)
>>> @@ -1134,7 +1134,14 @@
>>>  	if (partmatch)
>>>  		return partmatch;
>>>  
>>> -	printf("\nUnknown vendor:board from coreboot table or -m option: %s:%s\n\n", vendor, part);
>>> +	if (partvendor_from_cbtable) {
>>> +		printf("vendor:board from coreboot table is %s:%s, apparently "
>>> +		       "no board specific flash chip write enable is needed.\n",
>>> +		       vendor, part);
>>> +	} else {
>>> +		printf("\nUnknown vendor:board from -m option: %s:%s\n\n",
>>> +		       vendor, part);
>>> +	}
>>>  	return NULL;
>>>  }
>>>   
>>>     
>>>       
>> Can we get a method to make the coreboot table case not output any odd
>> technical message at all?
>>   
>>     
> Sure, I can remove the if part and transform the else part to
> if (!partvendor_from_cbtable)
>
> Would that be OK for you?
I think that's better... the mainboard and vendor are printed before, so
in case something would go wrong, we'd still know from a report which
board it is..



-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866