[flashrom] [PATCH] protection-free boards
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Mon Jul 27 17:19:11 CEST 2009
On 25.07.2009 12:12, Stefan Reinauer wrote:
> this patch makes flashrom "protection-free boards" friendly when
> coreboot is running by making the board->enable() function optional in
> the board structure.
>
> Index: board_enable.c
> ===================================================================
> --- board_enable.c (revision 667)
> +++ board_enable.c (working copy)
> @@ -1186,8 +1186,8 @@
> if (!board)
> board = board_match_pci_card_ids();
>
> - if (board) {
> - printf("Found board \"%s %s\", enabling flash write... ",
> + if (board && board->enable) {
> + printf("Disabling flash write protection for board \"%s %s\"... ",
> board->vendor_name, board->board_name);
>
> ret = board->enable(board->vendor_name);
This means you have to add an empty board enable for every single board
supported by coreboot. It would be a lot better to check if we got the
board name from lbtable, then print a message "found board xy,
apparently no board specific write enable needed".
I'll send a patch.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the flashrom
mailing list