[flashrom] [patch] add intel_piix4_gpo_set()

Luc Verhaegen libv at skynet.be
Tue Jul 7 15:13:20 CEST 2009


On Tue, Jul 07, 2009 at 03:10:32PM +0200, Luc Verhaegen wrote:
> This is code from a an old board enable that i sent in 3 weeks ago. This 
> board enable was not necessary (as flashing worked just fine without it 
> too). But this function was also used to clean up the board enable for 
> the epox ep bx3.
> 
> I have tracked down the person for whom i wrote this board enable 2 
> years ago: irc user nyu, aka Robert Millan.
> 
> Robert, can you verify that this code is not a regression for you?
> 
> Uwe, in the original mail thread 
> (http://www.coreboot.org/pipermail/coreboot/2009-June/049789.html) you 
> had several suggestions. I have taken over unsigned int and the 
> bitshift, but i do mot like to put "PIIX4{,E,M}" everywhere. 
> "PIIX4{,E,M}" all over clutters up the place, and i fear that printing 
> this to the user will generate more confusion than it will ever remove.
> Instead i have adjusted the initial function comment to mention this so 
> that developers can rest assured in future that this will also be valid 
> for their future board enables.
> 
> Luc Verhaegen.

Urgh, should've been an "@" instead of " at "... Bouncing original 
message to victims as well.

Luc Verhaegen.




More information about the flashrom mailing list