[flashrom] [PATCH] Convert flashchips to use struct eraseblock - AMD

Sean Nelson audiohacked at gmail.com
Tue Dec 22 10:36:52 CET 2009

On 12/22/09 12:09 AM, Carl-Daniel Hailfinger wrote:
> A few comments:
> Some chips had erase_chip_jedec as erase function (AM_29F002BB,
> AM_29F002BT) but it seems you dropped calls to that function completely.
> Does the datasheet forbid chip erase or is this a problem with
> mismatched prototypes? If you need an example of how a wrapper can be
> created, look at spi.c:spi_block_erase_60() which performs exactly that
> task with error checking.
Flash.h says: The default entry is a chip-sized virtual block together 
with the chip erase function. I guess I was wrong to assume the default 
behavior was to use erase_chip_jedec if ".block_erase=NULL".

Fixed everything asked/suggested. Added used prototypes to chipdrivers.h

Signed-off-by: Sean Nelson <audiohacked at gmail.com>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: AMD-flashchips-convert-to-blockerasers.diff
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20091222/a8fe25c0/attachment.ksh>

More information about the flashrom mailing list