[flashrom] [PATCH] Split hw access and chip drivers out of flash.h
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Mon Dec 14 04:52:32 CET 2009
On 14.12.2009 03:50, Idwer Vollering wrote:
> The given patch builds fine on "FreeBSD 8.0-RELEASE i386" but for that
> platform a patch for Makefile is needed. I have attached that patch.
>
> Signed-off-by: Idwer Vollering <vidwer at gmail.com>
>
>
> --- Makefile (revision 797)
> +++ Makefile (working copy)
> @@ -226,7 +226,7 @@
> @$(shell ( echo "#include <pci/pci.h>"; \
> echo "int main(int argc, char **argv)"; \
> echo "{ return 0; }"; ) > .test1.c )
> - @$(CC) $(CFLAGS) $(LDFLAGS) .test1.c -o .test1 $(LIBS) >/dev/null 2>&1 && \
> + @$(CC) -c $(CFLAGS) $(LDFLAGS) .test1.c -o .test1 $(LIBS) >/dev/null 2>&1 && \
>
The problem is that this is a linker test and -c explicitly disables the
linker, so your patch can be simplified by replacing the whole call by
/bin/true.
The correct fix would be not to abort here and retry with libz instead.
That's difficult to handle in our current Makefile.
> echo "found." || ( echo "not found."; echo; \
> echo "Please install libpci (package pciutils)."; \
> echo "See README for more information."; echo; \
>
Regards,
Carl-Daniel
--
Developer quote of the month:
"We are juggling too many chainsaws and flaming arrows and tigers."
More information about the flashrom
mailing list