[flashrom] [PATCH] common print infrastructure

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Dec 12 03:58:00 CET 2009

Awesome stuff. A must-have for 0.9.2. It touches a lot of code, so I'd
like to merge it as the last patch before 0.9.2 to minimize conflicts.

Minor comments:
- MSG_NORMAL: Not 100% sure if this name is best (_INFO or _NOTICE or
_DEFAULT maybe).
- flashrom_print.c: Maybe rename it to flashrom_output.c and move stuff
like progress printing in there, but I'm open to leaving it as is.
- Conditional compilation: Should the code in flashrom_print.c be #ifdef
STANDALONE or somesuch?
- Makefile: Did you forget to hook up the new file in Makefile?


Developer quote of the month: 
"We are juggling too many chainsaws and flaming arrows and tigers."

More information about the flashrom mailing list